Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: treat undefined value for compoundVariants as false #210

Conversation

Tokky0425
Copy link
Contributor

@Tokky0425 Tokky0425 commented Aug 11, 2024

Description

This fixes a bug where using compoundVariants with a boolean variant doesn't recognize undefined as equivalent to false.

bug reproduction code:

const h1 = tv({
  base: "",
  variants: {
    isBig: {
      true: "text-5xl",
      false: "text-2xl",
    },
  },
  compoundVariants: [
    {
      isBig: false,
      class: "text-red-500",
    },
  ],
});

h1({ isBig: undefined }) // should get "text-2xl text-red-500", but it's getting "text-2xl"

The bug is reported in #209

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the Style Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@lloydjatkinson
Copy link

Can this be merged and released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants